Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Old Python Dependencies #4256

Merged
merged 3 commits into from
Feb 27, 2019
Merged

Removes Old Python Dependencies #4256

merged 3 commits into from
Feb 27, 2019

Conversation

Coop56
Copy link
Contributor

@Coop56 Coop56 commented Feb 26, 2019

Removes unnecessary dependencies from the requirements.txt and settings.py files. This PR is connected to issue #4255. I verified that the tests pass locally. They're also working on Travis CI now as well.

All of these dependencies were checked against the Python codebase to make sure they weren't being used, and the tests seem to agree. I also did some manual smoke testing to make sure nothing was broken. If the Travis CI tests show anything different, or if anyone sees a dependency they think we still need I'll take a look and add them back if necessary.

Copy link
Member

@travislbrundage travislbrundage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afabiani
Copy link
Member

seems good to me

@afabiani afabiani merged commit 418f62f into GeoNode:master Feb 27, 2019
@afabiani
Copy link
Member

Thanks @Coop56

@Coop56 Coop56 deleted the audit-python-requirements branch March 7, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants