Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #10684] Remote Services with the same prefix create layers which won't be allow to edit metadata #10682

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Feb 22, 2023

References: [Fixes #10684] Remote Services with the same prefix create layers which won't be allow to edit metadata

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani added the minor A low priority issue which might affect only some users and /or not the main functionality label Feb 22, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 22, 2023
@afabiani afabiani added this to the 4.0.3 milestone Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #10682 (1255979) into 4.0.x (dd1cac4) will decrease coverage by 0.01%.
The diff coverage is 38.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##            4.0.x   #10682      +/-   ##
==========================================
- Coverage   61.94%   61.94%   -0.01%     
==========================================
  Files         827      827              
  Lines       50902    50908       +6     
  Branches     6554     6554              
==========================================
+ Hits        31530    31533       +3     
- Misses      17689    17691       +2     
- Partials     1683     1684       +1     

@afabiani afabiani merged commit b39b440 into 4.0.x Feb 23, 2023
@afabiani afabiani deleted the hardenining_patch_1_4.0.x branch February 23, 2023 08:43
@afabiani afabiani changed the title [Hardening] Make sure we resolve a Dataset even if more Services have… [Fixes #10684] Remote Services with the same prefix create layers which won't be allow to edit metadata Feb 23, 2023
@afabiani afabiani self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed minor A low priority issue which might affect only some users and /or not the main functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant