Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNIP-62: Contribute back upstream menu management from IGAD #4249

Closed
afabiani opened this issue Feb 22, 2019 · 0 comments
Closed

GNIP-62: Contribute back upstream menu management from IGAD #4249

afabiani opened this issue Feb 22, 2019 · 0 comments
Assignees
@afabiani
Labels
gnip A GeoNodeImprovementProcess Issue
Milestone
2.10

Comments

@afabiani
Copy link
Member

Generalize and simplify the menu management system implemented for IGAD.
The generic implementation to be ported upstream should provide a model to define menus and a generic "placeholder" concept to be integrated inside custom tempaltes through template tags.

Models

  • menu_placeholder: represents a logical container for menus. A template tag will provide the list of menus linked to this placeholder to be rendered in a specific area of the template HTML.

    • id
    • name

  • menu: the links container. With bootstrap it could be rendered as a dropdown title

    • id
    • title
    • placeholder_id: FK to menu_placeholder
    • order: menus within the same placeholder will be rendered according to this (optional) value. It represents a relative weight

image

  • menu_item:
    • id
    • title
    • menu_id: FK to menu
    • order
    • blank_target: boolean flag to specify if the link should open a new page
    • url: free input. Internal pages will be define with relative urls, external pages with absolute url.

image

Template tags

A set of template tags should be implemented to provide the template developer the option to obtain:

  • list of menu objects for a certain placeholder
  • list of menu_item objects for a certain menu

image

We would also provide a "rendered" option to obtain a complete placehoder and / or single menu rendered according to a default template, i.e. Bootstrap themed as the other menus in vanilla GeoNode.

image
@afabiani afabiani added gnip A GeoNodeImprovementProcess Issue feature A new feature to be added to the codebase labels Feb 22, 2019
@afabiani afabiani self-assigned this Feb 22, 2019
@afabiani afabiani mentioned this issue Feb 22, 2019
Merged
afabiani pushed a commit that referenced this issue Feb 27, 2019
Merge pull request #4250 from GeoNode/GNIP_4249
9292659 
[Closes #4249] Contribute back upstream menu management from IGAD
gannebamm added a commit to gannebamm/geonode that referenced this issue Mar 1, 2019
@gannebamm
squash merge commits from base repo to fork (#3)
b9a23d5 
* introduce new GEOSERVER_WEB_UI_LOCATION options

* Added chinese to ALL_LANGUAGES enumeration

* improve layer_thumbnail view

* improve map_thumbnail view

* fix map_thumbnail returned None instead.

* fix layer_thumbnail returned None instead.

* proxy auth refactoring with extended checks

* use requests retry to improve geonode/geoserver connection

* fix import

* fix force list status code

* Related to fix for GeoNode#4178

*  - fix pavemenet cmdopts options

* fix flake8

* fix flake8

* fixed mixing of token object and string in login/logout

* fixed pep8 issues

* fixed another pep8 issue

* Adding all Oauth2 endpoints to lockdown exempt uris

* fixed exception retrieving token object from empty session token

*  - Backporting GEOSERVER_WEB_UI_LOCATION to sample local settings

* Update oauth.py

* Cleaning up session if no valid access_token key has been found

* [Security Cleanup] - Remove unuseful and potentially blocking calls from signals and login/out calls

* Use gs instead of geoserver for URLs in Docker

* Includes additional fields in the search index

* add async_thumbnail to improve upload time

* use celery first if enabled

* disable threading in test 

we need to use TestCase threading aware

* Fix handling of missing layers.

When a missing layer is found during map_new the layer
_resolve_layer was not throwing a missing object exception but
was throwing Http404.  As Http404 was uncaught it was causing
the loop to fail instead of ignoring the missing data.

* use celery task to generate thumbnails

* Remove unwanted line of code in worldmap client

* moved login/logout callbacks to profile module; renamed oauth utils to auth

* remove unused import

* Make sure geogig can be created in a schema other than public

* Fix missing replacement of geoserver public location (GeoNode#4215)

* Fix missing replacement of geoserver public location

* Fix diff visualization

* Revert " Includes additional layer fields in the search index" (GeoNode#4217)

* Revert " Includes additional layer fields in the search index"

* Keep fields which don't affect the upload failure

* Remove not used settings sample

* [Related to GeoNode#4219] - mitigates the issue: Delayed Security Sync Task seems causing issues with sqlite queries

* Update requirements.txt

* Update requirements_docs.txt

* Update requirements.txt

* Update requirements_docs.txt

* filter by vector time layers is not working when haystack is enabled.
as for vector_time layer, 'vectorTimeSeries' is indexed instead of 'vector_time'

* for haystack
also get 'vector_time' layers when 'vector' type is selected
as 'vector' is super type of 'vector_time'(same behavior of rest api)

* Add rabbitmq volume

* [minor] There was a wrong 'expiring' check on purging old tokens

* use regex to extract schema

* Add rabbitmq volume to main docker-compose.yml

* Wait for GeoServer and PostgreSQL instead of failing

* Use geoserver instead of gs (partial revert)

* fix Object of type Map is not JSON serializable

*  - add missing header to Python file

* Add suffix geoserver to BASEURL

* Fixed a broken link in WorldMap documentation

* use 'update' queue instead if using the default

set task queue for  the thumbnail_task to 'update' queue instead of using the default

* Remove extra Postgres wait

* Add ON_ERROR_STOP=1

* Use custom Postgres password

* Use DATABASE_URL in pgdumper

* Improve comment about POSTGRES_PASSWORD

* Update GeoServer to 2.14.2

* Add support for plugins

* Typo fix

* Test with geonode-selenium

* Import SSL Certificate for GeoServer

* [Fixes GeoNode#4247] 404 error on CSV upload

* Fixes Travis geonode-selenium build

* Fixes Travis geonode-selenium build

* Fixes Travis geonode-selenium build

* Fixes Travis geonode-selenium build

* Fixes Travis geonode-selenium build

* Fixes Travis geonode-selenium build

* [Closes GeoNode#4249] Contribute back upstream menu management from IGAD

*  - Fix smoke test cases

*  - Fix smoke test cases

* Bump django-geoexplorer-worldmap==4.0.63

* Disable system_site_packages for geonode-selenium

* Removes unnecessary dependencies from the requirements.txt and settings.py files.

* Adds back pyopenssl to requirements.txt.

* [Fixes GeoNode#4254] Pavement YAMLLoadWarning

* [minor] removing redoundant middleware class from settings
@afabiani afabiani modified the milestone: 2.10 Jun 24, 2019
@afabiani afabiani removed the feature A new feature to be added to the codebase label Aug 22, 2019
@afabiani afabiani changed the title Contribute back upstream menu management from IGAD GNIP-62: Contribute back upstream menu management from IGAD Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afabiani afabiani

Labels
gnip A GeoNodeImprovementProcess Issue
Projects
None yet
Milestone
2.10
Development

No branches or pull requests
1 participant
@afabiani