Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assemblies are not Strongly Named, hence unusable to me in current form #123

Closed
peSHIr opened this issue Apr 24, 2019 · 7 comments
Closed
Assignees

Comments

@peSHIr
Copy link

peSHIr commented Apr 24, 2019

I tried to reference your NuGet package, but unfortunately (as my C# solution consists of Strongly Named assemblies), all I get at runtime isthe following exception:

System.IO.FileLoadException: 'Could not load file or assembly '[name], Version=#.#.#.#, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)'

Could you please update your package to be strongly named? Or else I see no other option to include some of your source code in my own instead of referencing your NuGet package, which sort of defeats the whole purpose, doesn't it...?

@xfischer xfischer self-assigned this Apr 24, 2019
@matt-lethargic
Copy link
Member

Hi @peSHIr in all honesty I've never created a Strongly Named assembly, let me do some reading and I'll back to you.

@xfischer what are your thoughts on this?

@matt-lethargic
Copy link
Member

So I've looked into this and the easiest way to do this is according to this article is just creating a file in using Visual Studio. does anyone know the effect it would have on the status quo as it is? Will everything just work as normal for the current users?

@peSHIr
Copy link
Author

peSHIr commented Jul 13, 2019 via email

@SimonCropp
Copy link
Contributor

so you want a pull request for this?

@xfischer
Copy link
Member

xfischer commented Aug 6, 2019

Yep, that would be nice ;)

@SimonCropp
Copy link
Contributor

#127

@xfischer
Copy link
Member

xfischer commented Aug 6, 2019

Thanks again @SimonCropp !

@xfischer xfischer closed this as completed Aug 6, 2019
xfischer added a commit that referenced this issue Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants