Improve the readability of the grdview function #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I worked on PR #750 based on the implemention of the `grdview` function, I found that the `grdview` codes are a little difficult to understand. The main reason is that `contextlib.ExitStack()` is new to me. Another reason is that these two codes `fname = stack.enter_context(file_context)` and `arg_str = " ".join([fname, build_arg_string(kwargs)])` are separated by the long `if` block.
seisman
added
enhancement
Member
Author
|
@weiji14 Please see if you agree with these changes. |
weiji14
approved these changes
Dec 19, 2020
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Yep, looks good! Better to keep the variables fname closer to where it is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
When I worked on PR #750 based on the implemention of the
grdviewfunction,I found that the
grdviewcodes are a little difficult to understand.The main reason is that
contextlib.ExitStack()is new to me.Another reason is that these two codes
fname = stack.enter_context(file_context)and
arg_str = " ".join([fname, build_arg_string(kwargs)])areseparated by the long
ifblock.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically