-
Notifications
You must be signed in to change notification settings - Fork 235
Let Figure.text() support record-by-record transparency #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dfcd84e to
088fe53
Compare
|
/format |
weiji14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style checks are failing, and we really need to refactor this text function (along with #483).
pygmt/base_plotting.py:1377:4: R0914: Too many local variables (16/15) (too-many-locals)
pygmt/base_plotting.py:1377:4: R0912: Too many branches (13/12) (too-many-branches)
Yes, let's leave it to future PRs. |
weiji14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then!
Description of proposed changes
This PR implements the record-by-record transparency feature for
Figure.text()function.Example:
Output:
Fixes #615.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically