CI: Fix the 'Greet First-Time Contributors' workflow - #4820
Closed
seisman wants to merge 1 commit into
Closed
Conversation
seisman
commented
Aug 12, 2026
|
|
||
| on: | ||
| pull_request: | ||
| pull_request_target: |
Member
Author
There was a problem hiding this comment.
zizmor marks pull_request_target as a dangerous trigger:
--> .github/workflows/welcome.yml:7:1
|
7 | / on:
8 | | pull_request_target:
9 | | types:
10 | | - opened
11 | | issues:
12 | | types:
13 | | - opened
| |______________^ pull_request_target is almost always used insecurely
|
= note: audit confidence → Medium
= help: audit documentation → https://docs.zizmor.sh/audits/#dangerous-triggers
but maybe it's OK since the workflow only contains one action?
Member
There was a problem hiding this comment.
Let's not risk it, especially for PRs. Too hard to secure against random actors nowadays.
I think first time contributors opening a PR get a pop up on the GitHub UI that points to contributing.md so we could just put this info there?
Member
Author
There was a problem hiding this comment.
Do you mean adding a new section to CONTRIBUTING.md?
Member
There was a problem hiding this comment.
Member
Author
|
OK. Closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The "Greet First-Time Contributors" workflows works well for issues (#4815 (comment)), but not for pull requests (e.g., #4808, https://github.com/GenericMappingTools/pygmt/actions/runs/31300559514/job/93216830178?pr=4808).
This PR fixes the issue by changing the triggering event from
pull_requesttopull_request_target.I didn't test it. Will know if it works or not when merging #4771.