Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Apr 11, 2022

Description of proposed changes

Move matplotlib import statement inside the check_figures_equal function, so that the cache_data workflow doesn't need matplotlib installed.

Address #1823 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Apr 11, 2022
@seisman seisman added this to the 0.6.1 milestone Apr 11, 2022
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Apr 11, 2022
@seisman
Copy link
Member Author

seisman commented Apr 11, 2022

@seisman seisman modified the milestones: 0.6.1, 0.7.0 Apr 11, 2022
@seisman seisman requested a review from weiji14 April 11, 2022 15:58
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Apr 12, 2022
@seisman seisman merged commit d68b6b5 into main Apr 13, 2022
@seisman seisman deleted the optional-matplotlib branch April 13, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants