Add tomli as a dependency in GitHub Actions CI #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tomli to fix the GitHub Actions CI test breakages reported in #1392. This is a temporary measure until `pytest-cov>2.12.1` is released.
weiji14
added
maintenance
The optional `[toml]` part is `pip` syntax, and not needed for `conda` or `mamba` install.
seisman
reviewed
Oct 3, 2021
.github/workflows/ci_tests.yaml
Outdated
| ${{ matrix.optional-packages }} \ | ||
| coverage[toml] dvc=2.3.0 make pytest>=6.0 \ | ||
| pytest-cov pytest-mpl sphinx-gallery | ||
| coverage dvc=2.3.0 make pytest>=6.0 \ |
Member
There was a problem hiding this comment.
Do you know why we have coverage here, but not in "ci_tests_dev.yaml"?
Member
Author
There was a problem hiding this comment.
Well, git blame shows that coverage[toml] was added by you in #1033, so I'll need to ask you that! We could probably removecoverage though, since pytest-cov depends on it.
Member
There was a problem hiding this comment.
😄 Let's remove it and see everything works well.
seisman
approved these changes
Oct 3, 2021
6 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
) Adding tomli to fix the GitHub Actions CI test breakages reported in GenericMappingTools#1392. This is a temporary measure until `pytest-cov>2.12.1` is released. * Remove coverage dependency since it is required by pytest-cov already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adding tomli to fix the GitHub Actions CI test breakages reported in #1392. This is a temporary measure until
pytest-cov>2.12.1is released. This is similar to #1401, but applied to theci_tests.yamlinstead of theci_tests_dev.yamlfile.Also remove
coveragefrom theenvironment.ymlfile since it is required bypytest-covalready.Fixes #1392
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version