Add missing aliases to grd2xyz #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willschlitzer
added
documentation
willschlitzer
changed the title
maxrjones
reviewed
Oct 6, 2021
maxrjones
reviewed
Oct 6, 2021
pygmt/src/grd2xyz.py
Outdated
| R="region", | ||
| V="verbose", | ||
| W="weight", | ||
| Z="binary", |
Member
There was a problem hiding this comment.
binary is already used as the name of a common option. Please select a different alias for Z and add b="binary".
Contributor
Author
There was a problem hiding this comment.
Updated to z_convention and added b
5 tasks
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
maxrjones
approved these changes
Oct 27, 2021
maxrjones
added
the
final review call
weiji14
approved these changes
Oct 27, 2021
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Just a few more common aliases to add, otherwise all good!
seisman
approved these changes
Oct 28, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
michaelgrund
approved these changes
Oct 28, 2021
willschlitzer
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1284 and wraps additional parameters.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version