Expand table-like input options for pygmt.surface #1455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrjones
reviewed
Aug 19, 2021
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Member
|
/format |
maxrjones
reviewed
Aug 22, 2021
Member
|
Ping @daroari to address the comment #1455 (review) |
Member
|
/format |
Member
|
Hi @daroari, do you think you will have time to finish this pull request? It would be great to get it added to PyGMT 😄 If not, we can either close the PR or I could push the remaining changes needed to this branch, whichever you prefer. |
Contributor
Author
|
Hi @meghanrjones. Sorry for the delayed response. Would you please push the remaining changes? I was going to do it, but I am not able to do it right now. Sorry for the inconvenience :( |
seisman
approved these changes
Sep 21, 2021
seisman
added
the
final review call
weiji14
approved these changes
Sep 21, 2021
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Thumbs up from me. Technically, it would be nice to have a unit test to make sure this works (e.g. using pytest.mark.parametrize like for blockm* in #1523), but ok to do it another time too 🙂
5 tasks
maxrjones
added
eswn-workshop
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…s#1455) * Expand table-like input options for pygmt.surface * Remove unused imports and variables * Update docstring for data Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR expands the table-like input options for pygmt.surface
Closes #1443
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version