Skip to content

Conversation

@MichaeINeumann
Copy link
Contributor

@MichaeINeumann MichaeINeumann commented Mar 25, 2021

Description of proposed changes

Replace (Match case and WholeWord) "pandas.Dataframe" to "pandas.DataFrame"

Fixes #1123

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@welcome
Copy link

welcome bot commented Mar 25, 2021

💖 Thanks for opening this pull request! 💖

Please make sure you read our contributing guidelines and abide by our code of conduct.

A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to do this! 🎉

@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 25, 2021
@seisman seisman added this to the 0.4.0 milestone Mar 25, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaeINeumann Thanks for your quick fix!

Just a few tiny suggestions to remove the extra whitespace before pandas.DataFrame.

@seisman seisman changed the title Fix #1123 "pandas.Dataframe" to "pandas.DataFrame" in pygmt/datasets/… Fix "pandas.Dataframe" to "pandas.DataFrame" in pygmt/datasets/samples.py Mar 25, 2021
@seisman seisman added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Mar 25, 2021
@MichaeINeumann
Copy link
Contributor Author

MichaeINeumann commented Mar 25, 2021

@seisman "Just a few tiny suggestions to remove the extra whitespace before pandas.DataFrame."
Sorry, you did this changes allready? It's my first time at gitHub. Do you expected enything else from me?
THX

@seisman
Copy link
Member

seisman commented Mar 25, 2021

"Just a few tiny suggestions to remove the extra whitespace before pandas.DataFrame."
Sorry, you did this changes? It's my first time at gitHub. Do you expected enything else from me? THX

Sorry, I shouldn't assume any git or github knowledge for new contributors.

As you can see, I just made three suggestions for this PR, but they're NOT committed to this PR yet:

image

If you agree with the suggested changes, you can click the "Commit suggestion" button to make the changes. Each time you click the button, the suggested changes will be committed to your branch.

Alternatively, you can go to the "Files changes" tab:

image

and click the "Add the suggestion to batch" button,

image

and then click the "Commit suggestion" button on the top, which will make all changes in a single commit:
image

Thanks for the very good Explanation.

Co-authored-by: Dongdong Tian <[email protected]>
@seisman
Copy link
Member

seisman commented Mar 25, 2021

Great! Just one more tip, when you make some changes and submit a PR, please choose "Create a new branch for this commit and start a pull request" and click on the "Propose changes" button to open a pull request.

image

It's much better than choosing "commit directly to the master branch".

@seisman seisman self-assigned this Mar 25, 2021
@seisman seisman merged commit f012ee6 into GenericMappingTools:master Mar 25, 2021
@welcome
Copy link

welcome bot commented Mar 25, 2021

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉

Please open a new pull request to add yourself to the AUTHORS.md file. We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix "pandas.Dataframe" to "pandas.DataFrame" in pygmt/datasets/samples.py

2 participants