Refactor text to use virtualfile_from_data

[seisman]

Description of proposed changes

• Refactor text to use virtualfile_from_data
• Raise exceptions for invalid inputs
• Add more tests for invalid inputs

Related to #949.

Reminders

• Run make format and make check to make sure the code follows the style guide.
• Add tests for new features or tests that would have caught the bug that you're fixing.
• Add new public functions/methods/classes to doc/api/index.rst.
• Write detailed docstrings for all functions/methods.
• If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

• /format: automatically format and lint the code
• /test-gmt-dev: run full tests on the latest GMT development version

[maxrjones]

Looks good to me. I only had a couple small comments.

[maxrjones]

Should be fixed now, correct?

Suggested change

# text must be in str type, see issue #706

[seisman]

text must be in str type

This statement is still True.

[seisman]

Thanks for your suggestions. I'll mark this PR as draft, because I don't like the current implemention.

[weiji14]

Had a quick glance and can't see any major issues with this refactor. Is there anything else remaining you want to work on here @seisman?

[seisman]

Is there anything else remaining you want to work on here?

I plan to not make more reactors in this PR to make it easier to review.

[weiji14]

Looks ok to me. Sugest @meghanrjones (or someone else) to give this another review since it's been over a year since they approved this PR!

[seisman]

Ping @meghanrjones to give this PR a final review.

[maxrjones]

Sorry for not getting back to this in time to be helpful

[seisman]

No worries. You can still leave your comments if there are any 😄