Skip to content

Conversation

@maxrjones
Copy link
Member

Description of proposed changes

This PR adds API_GIT_COMMIT to the API keywords for GMT_Get_Default, so that wrappers can more easily access the commit information for the GMT library (xref GenericMappingTools/pygmt#1838).

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@maxrjones maxrjones added the enhancement Improving an existing feature label Mar 28, 2022
@seisman
Copy link
Member

seisman commented Mar 29, 2022

I'm wondering if API_BIN_VERSION is a better name here, because for public releases, it's a version string like 6.4.0 without git commit information.

@seisman
Copy link
Member

seisman commented Mar 29, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improving an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants