Fix error when x-dir is flipped for an image #4173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The various signs in -JX±width/±height did not work for negative xwidth. THe logic is a bit messy now but works. In the revised branch we will simplify this futher.
Member
Author
|
I think doing #4163 has been helpful since so far it has revealed (and let us fix( bugs in both grdmix and grdimage. Hopefully, someone can approve this one so I can merge it back into that branch. |
joa-quim
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For various signs in -JX±width/±height the plotting of an image did not work for negative width. The logic is a bit messier now but works. In the revised branch (#4163) we will simplify this further. This completes the fix for both x-dir and -ydir changing directions.