Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Reset selectedRange length before resign first responder #53

Merged
merged 1 commit into from
Feb 11, 2019
Merged

[Bug] Reset selectedRange length before resign first responder #53

merged 1 commit into from
Feb 11, 2019

Conversation

GeekTree0101
Copy link
Owner

Why need this change?:

  • Reset selectedRange length with sustain location before resign first responder about activted textView

Change made & impact:

  • selectedRange length will be zero at editableTextNodeDidFinishEditing: method

Test Scope:

  • pass

Vertified snapshots (optional)

@GeekTree0101 GeekTree0101 added the bug Something isn't working label Feb 11, 2019
@GeekTree0101
Copy link
Owner Author 

 Executed 49 tests, with 0 failures (0 unexpected) in 0.504 (0.671) seconds

coverage bug

OhKanghoon
OhKanghoon approved these changes Feb 11, 2019
View reviewed changes
Copy link
Collaborator

@OhKanghoon OhKanghoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@OhKanghoon OhKanghoon merged commit 9b8381a into master Feb 11, 2019
@OhKanghoon OhKanghoon deleted the bug/VEditorKit-Reset-selectionRange-lenght-resign-first-respond-about-target-text-area branch February 11, 2019 05:39
GeekTree0101 added a commit that referenced this pull request Apr 15, 2019
@GeekTree0101
Rollback #53
04c1d24
@GeekTree0101 GeekTree0101 mentioned this pull request Apr 15, 2019
Merged
GeekTree0101 added a commit that referenced this pull request Apr 15, 2019
@GeekTree0101
Merge pull request #63 from GeekTree0101/bug/rollback-selectedRange-l…
003be29 
…ength-reset-pull-request

Rollback #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OhKanghoon OhKanghoon OhKanghoon approved these changes

Assignees

@OhKanghoon OhKanghoon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeekTree0101 @OhKanghoon