feat(config): 添加配置系统集成测试和文档#189
Merged
Merged
Conversation
- 添加 ArchitectureConfigIntegrationTests 验证架构初始化流程中配置加载 - 添加 GeneratedConfigConsumerIntegrationTests 测试消费者项目配置绑定功能 - 添加完整的游戏内容配置系统中文文档 - 添加生成配置目录和注册选项支持批量表注册与筛选 - 实现配置架构集成模板和热重载功能 - 添加跨表引用校验和运行时诊断功能 - 实现 VS Code 工具支持配置浏览和表单编辑 - 添加查询辅助方法支持按字段快速检索配置数据
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| C# |  |
Apr 6, 2026 9:24a.m. | Review ↗ |
| Secrets | |
Apr 6, 2026 9:24a.m. | Review ↗ |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds per-call filtering to aggregated generated-config registration. Changes
Sequence DiagramsequenceDiagram
participant Test
participant YamlConfigLoader
participant GeneratedCatalog as GeneratedCatalog (Tables...)
participant ShouldRegister as ShouldRegisterTable (Filter Helper)
participant Registry as Config Registry
Test->>YamlConfigLoader: RegisterAllGeneratedConfigTables(loader, options)
Note over YamlConfigLoader: options = {IncludedConfigDomains, IncludedTableNames, TableFilter}
loop for each metadata in GeneratedCatalog.Tables
YamlConfigLoader->>ShouldRegister: ShouldRegisterTable(metadata, options)
ShouldRegister-->>YamlConfigLoader: true/false
alt true
YamlConfigLoader->>Registry: RegisterTable(metadata, loader, ...)
else false
Note over YamlConfigLoader: Skip registration for this table
end
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
GFramework.Game.Tests/Config/GeneratedConfigConsumerIntegrationTests.cs (1)
188-282: Avoid maintaining a second copy of the schemas in this test.
CreateMonsterFiles()andCreateItemFiles()now duplicate the same contracts that already live in the test project’sschemas/inputs. If those copies drift, this stops being a true end-to-end consumer test because generation and runtime validation are no longer using the same schema.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@GFramework.Game.Tests/Config/GeneratedConfigConsumerIntegrationTests.cs` around lines 188 - 282, CreateMonsterFiles and CreateItemFiles duplicate schema definitions that already exist in the test project's schemas inputs; remove the hard-coded JSON/YAML literals and instead have those helpers copy or reference the existing schema and sample YAML files from the test project's "schemas/" and related input directories (use the existing CreateFile callers like CreateFile and the helpers CreateMonsterFiles/CreateItemFiles to read and write from the canonical source files rather than embedding new literals) so generation and runtime validation use the same single source of truth.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@GFramework.Game.Tests/Config/GeneratedConfigConsumerIntegrationTests.cs`:
- Around line 118-166: Extend the existing test
RegisterAllGeneratedConfigTables_Should_Support_Filtering_By_Domain_Table_Name_And_Predicate
to also exercise the "empty allow-list" branches by creating additional
ConfigRegistry/YamlConfigLoader pairs that call RegisterAllGeneratedConfigTables
with GeneratedConfigRegistrationOptions.IncludedConfigDomains =
Array.Empty<string>() and IncludedTableNames = Array.Empty<string>(); after
LoadAsync assert that these empty-list registries behave like the unrestricted
case (i.e., both Monster and Item tables are registered and accessible, similar
to the null/default behavior already asserted), using the existing
TryGetMonsterTable/TryGetItemTable assertions to validate the result.
---
Nitpick comments:
In `@GFramework.Game.Tests/Config/GeneratedConfigConsumerIntegrationTests.cs`:
- Around line 188-282: CreateMonsterFiles and CreateItemFiles duplicate schema
definitions that already exist in the test project's schemas inputs; remove the
hard-coded JSON/YAML literals and instead have those helpers copy or reference
the existing schema and sample YAML files from the test project's "schemas/" and
related input directories (use the existing CreateFile callers like CreateFile
and the helpers CreateMonsterFiles/CreateItemFiles to read and write from the
canonical source files rather than embedding new literals) so generation and
runtime validation use the same single source of truth.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f808215b-04b6-4fe5-887e-0021a0006594
📒 Files selected for processing (7)
GFramework.Game.Tests/Config/ArchitectureConfigIntegrationTests.csGFramework.Game.Tests/Config/GeneratedConfigConsumerIntegrationTests.csGFramework.Game.Tests/schemas/item.schema.jsonGFramework.SourceGenerators.Tests/Config/SchemaConfigGeneratorTests.csGFramework.SourceGenerators.Tests/Config/snapshots/SchemaConfigGenerator/GeneratedConfigCatalog.g.txtGFramework.SourceGenerators/Config/SchemaConfigGenerator.csdocs/zh-CN/game/config-system.md
- 创建AGENTS.md文档定义AI代理编码行为规则 - 包含环境能力清单、注释规则、代码风格要求 - 定义测试要求、安全规则和文档规范 - 添加端到端集成测试验证生成配置消费者功能 - 实现跨域配置表加载和强类型访问验证 - 添加按域、表名和自定义谓词过滤注册支持 - 提供完整的测试验证命令和执行期望说明
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Tests
Documentation