-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need version that doesn't rely on global #694
Comments
From what I read this should be solved at the cli side, try downgrading and await the final version |
Where did you read that? From what I've seen they removed node globals and don't plan on putting them back. See angular/angular-cli#9827 (comment) It does say at the end that "some of the issues will be resolved" but doesn't seem like he is referring to putting node globals back in. |
You're right, it doesn't look like they plan on changing that exact thing. I won't be able to publish until the weekend, so I still suggest to downgrade for now |
Thanks man! Just wanted to make sure you're still working on it before waiting. You still have the best chip control in the game man! Props to you! I've been watching the material guys attempt to combine input and chips and autocomplete into a similar functionality to no avail so far. |
Any chance to look at this over weekend? |
Hi @PTC-JoshuaMatthews, can you check v1.6.8? Thanks |
PLEASE MAKE SURE THAT:
I'm submitting a ... (check one with "x")
Current behavior
ngx-chips.js:933 Uncaught ReferenceError: global is not defined
at Object.../node_modules/ngx-chips/esm5/ngx-chips.js (ngx-chips.js:933)
at webpack_require (bootstrap:74)
at Object../main.ts (environment.ts:19)
at webpack_require (bootstrap:74)
at Object.0 (common.service.ts:6)
at webpack_require (bootstrap:74)
at checkDeferredModules (bootstrap:43)
at Array.webpackJsonpCallback [as push] (bootstrap:30)
at main.js:1
Expected behavior
Browser module should not depend on global
Minimal reproduction of the problem with instructions (if applicable)
Use @next angular cli to create a project. Install ngx-chips. Import it to a component. Load the project in browser.
What do you use to build your app?. Please specify the version
Angular version:
ngx-chips version:
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
The text was updated successfully, but these errors were encountered: