Support ember 3.10.0 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinJoyce
force-pushed
the
gj/spike-3.10-fix
branch
from
7745714
to
5eb25b6
Compare
GavinJoyce
commented
May 21, 2019
| @@ -0,0 +1,20 @@ | |||
| const __EMBER_METAL__ = Ember.__loader.require('@ember/-internals/metal'); | |||
There was a problem hiding this comment.
This works in Ember 3.8+ only. It should be possible to make it backwards compatible should we wish though, we just need to detect the version
something like this:
There was a problem hiding this comment.
From looking here it seems that its from Ember 3.10+
https://github.com/emberjs/ember.js/blob/v3.10.0/packages/@ember/-internals/metal/index.ts
|
Apart for the decorators test, which I've modified to pass, all tests are passing in Ember 3.8 and 3.10
|
2 tasks
|
closed in favour of adopted-ember-addons#641 and #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fork to unblock our ember 3.10.0 upgrade efforts.
adopted-ember-addons#641 tracks the attempt to upstream these changes