Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle steering return-to-centre #49

Merged
merged 3 commits into from
Jan 11, 2013

Conversation

crabmusket
Copy link
Contributor

Inspired by Charles Fusner's update to James Jacoby's original resource. These changes allow Vehicles to automatically centre their steering based on their current velocity. It makes vehicle handling much more realistic - and easier, especially with keyboard steering!

Recommended datablock settings for the Cheetah with this patch:

powerSteering = true;
steeringReturn = 1;
steeringReturnSpeedScale = 0.5;

steeringReturn is the main control for the amount of return in
the steering. Setting it to 0 (the default) disables steering return
completely.

steeringReturnSpeedScale is a multiplier on the amount of effect that
the vehicle's velocity has on its steering return.

powerSteering can be set to eliminate the effect of steering return on
user input. Without this flag set, the user will have a harder time
steering, because the wheels try to return as they steer. If this flag
is set, steering return will not be applied while the user is actually
steering, only when they release.
It happens in Vehicle::updateMove so it can apply to all vehicle
subclasses. It is applied to both x and y steering.
It was causing Vehicles to roll forwards with a constant velocity when
stationary, and ignore move->y.
@crabmusket
Copy link
Contributor Author

How do issues get labeled? Does someone have to come along and do them manually, or can we tag our own pull requests?

@DavidWyand-GG
Copy link
Member

I went through them manually from the Issues screen. GitHub doesn't seem to let you do it from the Pull Request itself. And feel free to tag your own requests.

@crabmusket
Copy link
Contributor Author

I can't seem to find a way to apply labels to issues. I may just be being dumb.

@DavidWyand-GG
Copy link
Member

No, it's not you. It looks like only a repo owner may change the labels for an issue. So you won't be able to label your issues after all.

@DavidWyand-GG
Copy link
Member

Before we can accept any changes to the repositories we'll need you to sign the Open Source Software Agreement. We've outlined the steps in the wiki: Contributing Page Please follow those steps and let me know when you're done. Thanks!

@crabmusket
Copy link
Contributor Author

Way ahead of you ;).

@thecelloman
Copy link
Contributor

Nice addition -- it really makes a difference!

thecelloman added a commit that referenced this pull request Jan 11, 2013
Vehicle steering return-to-centre merged into development branch.
@thecelloman thecelloman merged commit b2e2c7b into GarageGames:development Jan 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants