Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShapeEditor - Import Shape into, chaning node, and saving #252

Open
MusicMonkey5555 opened this issue Mar 11, 2013 · 2 comments
Open

ShapeEditor - Import Shape into, chaning node, and saving #252

MusicMonkey5555 opened this issue Mar 11, 2013 · 2 comments

Comments

@MusicMonkey5555
Copy link
Contributor

If use the Import Shape into feature, use the current detail level and then change the Object Node and click the save. It saves out everything except the Object Node change.

It just needs to save out a line saying %this.setObjectNode i the onLoad function.

I am going to look into trying to fix it, but figured I would post here first in case it can quickly be fixed by someone who has already messed with the code.

@MusicMonkey5555
Copy link
Contributor Author

Oh just as another note I am assuming that the bug is in PersistenceManager::saveDirtyObject some place in engine code. That is where I have tracked down the saving is happening, via ShapeEditor::saveConstructor in script.

Edit: It turns out that simply writes out the object. the call writeChangeSet on the TSShapeconstructor is what saves out the onLoad.

@MusicMonkey5555
Copy link
Contributor Author

in tsShapeConstruct.cpp if you comment out or delete line 2916 to 2925 or so it fixes the issue. Apparently it tries to change the addMesh command but that doesn't take a node only a mesh. This doesn't seem to cause any issues from my small testing and fixes the issue. let me know if anyone else has issues with it. I really need to take some time at work to get submitting to here integrated into our workflow.

lukaspj pushed a commit to lukaspj/Torque3D-Old that referenced this issue Oct 2, 2020
from jeff and tim: review of lighting impacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant