This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
Test python click 7.0 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 similar comments
grigouze
force-pushed
the
test_click_6.7_7.0
branch
from
a389f64
to
fe8178b
Compare
MoiTux
reviewed
Dec 23, 2018
setup.py
Outdated
| @@ -41,7 +41,7 @@ def run_tests(self): | |||
| version = re.compile(r".*__version__ = '(.*?)'", | |||
| re.S).match(v_file.read()).group(1) | |||
|
|
|||
| requires = ['setuptools', 'pyyaml', 'click>=3.1, <6.7', 'requests', 'IPy'] | |||
| requires = ['setuptools', 'pyyaml', 'click>=3.1, >=6.7', 'requests', 'IPy'] | |||
There was a problem hiding this comment.
no need to keep the click>=3.1 since >=3.7 will do it too
MoiTux
previously requested changes
Dec 23, 2018
There was a problem hiding this comment.
For me this is a very big breaking change, form what I read in the original issue form Click, just swapping param, should fix it, and should keep the compact.
Instead of doing this:
@click.option('--bg', '--background', default=False, is_flag=True,
help='Run command in background mode (default=False).')
Do this:
@click.option( '--background', '--bg', default=False, is_flag=True,
help='Run command in background mode (default=False).')
From a quick test I did on the vm.create it seems to works and keep compact witch the current parameters (still allow the use of both long param version)
MoiTux
reviewed
Dec 23, 2018
setup.py
Outdated
| @@ -41,7 +41,7 @@ def run_tests(self): | |||
| version = re.compile(r".*__version__ = '(.*?)'", | |||
| re.S).match(v_file.read()).group(1) | |||
|
|
|||
| requires = ['setuptools', 'pyyaml', 'click>=3.1, <6.7', 'requests', 'IPy'] | |||
| requires = ['setuptools', 'pyyaml', 'click>=3.1, >=6.7', 'requests', 'IPy'] | |||
|
|
|||
| tests_require = ['pytest', 'pytest-cov', 'tox'] | |||
| if sys.version_info < (2, 7): | |||
There was a problem hiding this comment.
With Click >= 7.0 python 2.6 is deprecated so this should not be needed anymore
supported version are: python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*",
|
@MoiTux It was just a test, i will not do the breaking changes :) |
grigouze
force-pushed
the
test_click_6.7_7.0
branch
2 times, most recently
from
3327ac0
to
bd3a1f1
Compare
- drop support of python 2.6 and 3.3 - must be click >= 7.0
grigouze
force-pushed
the
test_click_6.7_7.0
branch
from
bd3a1f1
to
ed97224
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.