Bugfix: RenderTexture's draw and drawBundled methods threw exceptions if context was lost.#642
Closed
stepan-beresnev wants to merge 1 commit intoGamua:masterfrom
Closed
Bugfix: RenderTexture's draw and drawBundled methods threw exceptions if context was lost.#642stepan-beresnev wants to merge 1 commit intoGamua:masterfrom
stepan-beresnev wants to merge 1 commit intoGamua:masterfrom
Conversation
Contributor
|
Thanks! I'll look into the complete "context" issue after the release of Starling 1.6. |
Contributor
|
Since this is a small change that shouldn't have any side effects, I changed my mind and added it right away. Thanks again! |
Author
|
Hello, Not sure, if you did it intentionally, but you didn't copy |
Contributor
|
That's intentional! "render" will never be called alone; it's always called from within "renderBundled". So it's enough to check the context in the latter method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's basically the same issue as was discussed here 627.