update viewnames for DRF 3.15 change [#187298296] #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#187298296]
uraniumanchor
force-pushed
the
187298296-drf-315
branch
from
609dd25 to
7f204ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Donation Tracker
Issue from Pivotal Tracker
See also #658, as this is when the issue was brought to my attention. Relevant issue from DRF: encode/django-rest-framework#8438
https://www.pivotaltracker.com/story/show/187298296
Description of the Change
When multiple possible paths go to the same viewset, DRF 3.15 added a check to ensure that they have different internal names so that you don't end up with ambiguity. In our case every path variant had its own explicit requirements so this didn't affect us, but it's a simple enough change. It mostly affected tests, and changing the helpers was enough to keep the tests green.
Verification Process
This change didn't affect the public API, just some internal bookkeeping. The tests are green, so that's good enough.