Skip to content

Conversation

ptrj
Copy link

@ptrj ptrj commented Oct 5, 2018

Docker support. Start game without tmux and game runs in foreground.
Why without tmux?
Hope it helps to push forward your docker repository.

Docker support. Start game without tmux and game runs in foreground.
@ghost ghost added the Status: dev queue label Oct 5, 2018
@dgibbs64 dgibbs64 changed the base branch from master to develop October 5, 2018 21:39
@dgibbs64
Copy link
Member

dgibbs64 commented Oct 5, 2018

This is great thank you. My docker knowledge is very limited so I am relying on more experienced docker developers to help.

Am i right tin saying that tmux doesn't run well in docker? if so it might mean that I treat all servers the same as teamspeak3 (no tmux)

@dgibbs64 dgibbs64 added the type: feature New feature or request label Oct 5, 2018
@ptrj
Copy link
Author

ptrj commented Oct 6, 2018

You are welcome. I'm not a docker guru, I'm a fan of LinuxGSM and I want to use the Docker in future.
Looks like tmux needs terminal inside Docker container. Argument "-t"

docker run -t -d image/name:version

Example above works, but if I use docker-compose or Docker orchestration like a Kubernetes, then it will not work.
Best practice for Docker container is one process running in foreground. If this process ends, then the container will terminate as well.
Then my opinion is, don't use tmux in container.
Oh, and when you speak about teamspeak, i forgot add some lines in command_start.sh

        if [ "${ts3serverpass}" == "1" ]; then
                if [ "${docker}" == "on" ]; then
                        ./ts3server_minimal_runscript.sh start serveradmin_password="${newpassword}" inifile="${servercfgfullpath}"
                else
                        ./ts3server_startscript.sh start serveradmin_password="${newpassword}" inifile="${servercfgfullpath}" > /dev/null 2>&1
                fi
        else
                if [ "${docker}" == "on" ]; then
                        ./ts3server_minimal_runscript.sh start inifile="${servercfgfullpath}"
                else
                        ./ts3server_startscript.sh start inifile="${servercfgfullpath}" > /dev/null 2>&1
                fi
        fi

Thank you

@dgibbs64
Copy link
Member

dgibbs64 commented Oct 6, 2018

Awesome! So basically treat docker almost as a remix replacement and that will be the best way to do it.

@dgibbs64 dgibbs64 closed this Jan 27, 2021
@dgibbs64 dgibbs64 deleted the branch GameServerManagers:develop January 27, 2021 20:51
@dgibbs64 dgibbs64 reopened this Jan 27, 2021
@h3o66 h3o66 added the branch conflicts Branch of pr has conflicts that need to be worked on label Jan 28, 2021
@Roni1993
Copy link

Hi @dgibbs64, I'm currently fiddling around with a docker-based setup for LGSM and I was stumbling upon this.
Is there any way I can support you with this PR?

@ptrj
Copy link
Author

ptrj commented Feb 21, 2022

Hi @dgibbs64,
I think we can close this RP, somewhere over the years to make a workable solution :-)

@ptrj ptrj closed this Feb 21, 2022
@ptrj ptrj deleted the feature/docker branch February 21, 2022 09:55
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

branch conflicts Branch of pr has conflicts that need to be worked on type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants