-
Notifications
You must be signed in to change notification settings - Fork 71
Work that I started but never finished #35
Conversation
|
The Dockerfile in this PR does have a few lines in it that seem to backpeddle on what we currently have in or may not be necessary. There's several depends missing from the last commit of it. I would favor the latest instead of this version. |
|
There are a lot of things I like in this PR. Cleaning up the useradd and groupadd to not include uid and gid looks good, as the Right now the dockerfile doesn't build in podman. It throws There's also some issues with your examples in the README that I'll pin down as I get time. Also it looks like you mispelled It looks like in develop and in fresh start you've actually moved to using volumes instead of bind mounts. Any specific reason behind this? I'm a fan of bind mounts and I think it would simplify managing config files when used in conjunction with the |
|
Thanks for this. I will address more later. I went with volumes because of flexibility over bind mounts. Some reasons can be found here. https://serverfault.com/questions/996785/docker-volumes-vs-mount-binds-what-are-the-use-cases |
Here is a branch I was working on but never finished. Please can anything useful be taken out of this