Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Conversation

@dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Apr 2, 2021

Here is a branch I was working on but never finished. Please can anything useful be taken out of this

@dgibbs64 dgibbs64 changed the base branch from master to develop April 2, 2021 09:19
@clairmont32
Copy link
Contributor

clairmont32 commented Apr 2, 2021

The Dockerfile in this PR does have a few lines in it that seem to backpeddle on what we currently have in or may not be necessary. There's several depends missing from the last commit of it. I would favor the latest instead of this version.

@BBBosp
Copy link
Contributor

BBBosp commented Apr 3, 2021

There are a lot of things I like in this PR. Cleaning up the useradd and groupadd to not include uid and gid looks good, as the --user tag we're putting in will manage that anyway.
A functional install of steamcmd is good, I was going to look at doing that soon anyway.
Using the auto install function for installing servers with an ENV like Grenade was looking to do is good to see.

Right now the dockerfile doesn't build in podman. It throws chfn: PAM: System error. One way to fix this is adding RUN ln -s -f /bin/true /usr/bin/chfn somewhere near the begining of the dockerfile. Even after it builds I get a lot of WARN[0108] SHELL is not supported for OCI image format, [/bin/bash -o pipefail -c] will be ignored. Must use `docker` format That I really havent looked into in depth.

There's also some issues with your examples in the README that I'll pin down as I get time. Also it looks like you mispelled home as hone in a file pathc on line 94 int he dockerfile.

It looks like in develop and in fresh start you've actually moved to using volumes instead of bind mounts. Any specific reason behind this? I'm a fan of bind mounts and I think it would simplify managing config files when used in conjunction with the --userflag.

@dgibbs64
Copy link
Member Author

dgibbs64 commented Apr 3, 2021

Thanks for this. I will address more later. I went with volumes because of flexibility over bind mounts. Some reasons can be found here. https://serverfault.com/questions/996785/docker-volumes-vs-mount-binds-what-are-the-use-cases

jusito added a commit to jusito/LinuxGSM-Docker that referenced this pull request Nov 11, 2021
@jusito jusito mentioned this pull request Dec 1, 2021
18 tasks
@dgibbs64 dgibbs64 closed this Jan 23, 2022
@dgibbs64 dgibbs64 deleted the fresh-start branch January 23, 2022 22:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants