Feature/maroon 424 planetary system #442
Conversation
new feature branch for Planetary System experiment
There was a problem hiding this comment.
Please rename it to e.g. planet_box or something similar.
There was a problem hiding this comment.
This object has many vertices. Please try to reduce the number of vertices for this model.
There was a problem hiding this comment.
same, many vertices for a simple object
There was a problem hiding this comment.
i think we can remove the detailed version (telescope_pars)
There was a problem hiding this comment.
Please use a name without "reduced" after deleting the detailed version.
| */ | ||
| #region PlanetInfoInstance | ||
| private static PlanetInfo _instance; | ||
| public static PlanetInfo Instance |
There was a problem hiding this comment.
Why do we need a static instance property for this class?
FindObjectOfType returns the first object in the scene and there are multiple planets with this class...
| { | ||
| //sun source: NASA.gov https://nssdc.gsfc.nasa.gov/planetary/factsheet/sunfact.html | ||
| case PlanetInformation.sun_0: | ||
| mass = 1988500f; |
There was a problem hiding this comment.
Why not via the inspector?
| float planetRotationPerSecond = 0; | ||
|
|
||
| //every 0.02 sec = 50x per sec | ||
| void FixedUpdate() |
| //360� rotation for each earth day (24h) in 1 FixedUpdate(0.02) * 50 for 1 sec | ||
| planetRotationPerSecond = (360 / -planetInfo.rotationPeriod) * (ROTATION_PERIOD_SCALE_FACTOR / 50); | ||
| transform.Rotate(new Vector3(0, planetRotationPerSecond, 0)); | ||
| //transform.Rotate(new Vector3(0, ((360 / -planetInfo.rotationPeriod) * (ROTATION_PERIOD_SCALE_FACTOR)), 0) * Time.deltaTime); |
There was a problem hiding this comment.
please remove unused code
| #endregion Slider | ||
|
|
||
| #region UIToggleButtons | ||
| [SerializeField] private Toggle toggleAllTrajectories; |
There was a problem hiding this comment.
We need to remove all of these UI dependencies from the planetary controller
Closes #424