feat: GET /users/me #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wally5077
reviewed
Jun 5, 2023
| import org.springframework.web.bind.annotation.RestController | ||
| import tw.waterballsa.gaas.application.usecases.GetUserUseCase | ||
| import tw.waterballsa.gaas.domain.User | ||
|
|
||
| @RestController | ||
| @RequestMapping("/users") |
Wally5077
reviewed
Jun 5, 2023
Comment on lines
33
to
50
| protected fun mockDefaultOidcUser(): OidcUser { | ||
| return mockOidcUser(User(User.Id("1"), "[email protected]", "winner5566")) | ||
| } | ||
|
|
||
| protected fun mockOidcUser(mockUser: User): OidcUser { | ||
| val idToken = OidcIdToken( | ||
| "token", | ||
| Instant.now(), | ||
| Instant.now().plusSeconds(60), | ||
| mapOf( | ||
| "sub" to mockUser.id!!.value, | ||
| "name" to mockUser.nickname, | ||
| "email" to mockUser.email | ||
| ) | ||
| ) | ||
| return DefaultOidcUser(emptyList(), idToken) |
Wally5077
requested changes
Jun 5, 2023
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/UserControllerTest.kt
Outdated
Show resolved
Hide resolved
lohas1107
force-pushed
the
feature/user-me
branch
from
66c7d79 to
999c952
Compare
ricksu978
requested changes
Jun 23, 2023
spring/src/main/kotlin/tw/waterballsa/gaas/spring/controllers/UserController.kt
Outdated
Show resolved
Hide resolved
lohas1107
force-pushed
the
feature/user-me
branch
2 times, most recently
from
bdaebd7 to
4ff10dd
Compare
lohas1107
force-pushed
the
feature/user-me
branch
from
4ff10dd to
9aa2ded
Compare
Wally5077
requested changes
Jun 25, 2023
application/src/main/kotlin/tw/waterballsa/gaas/application/usecases/GetUserMeUseCase.kt
Outdated
Show resolved
Hide resolved
| @@ -22,7 +22,7 @@ abstract class AbstractSpringBootTest { | |||
| @Autowired | |||
| private lateinit var objectMapper: ObjectMapper | |||
|
|
|||
| protected final val mockUser: User = User( | |||
| protected var mockUser: User = User( | |||
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/UserControllerTest.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/UserControllerTest.kt
Outdated
Show resolved
Hide resolved
spring/src/main/kotlin/tw/waterballsa/gaas/spring/controllers/UserController.kt
Outdated
Show resolved
Hide resolved
spring/src/main/kotlin/tw/waterballsa/gaas/spring/controllers/UserController.kt
Outdated
Show resolved
Hide resolved
spring/src/main/kotlin/tw/waterballsa/gaas/spring/controllers/UserController.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/UserControllerTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change? / Root cause:
Changes made:
Test Scope / Change impact:
Issue
GET /users/me#77