Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fast join #159

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Feature/fast join #159

merged 2 commits into from
Sep 24, 2023

Conversation

kuoche1712003
Copy link
Contributor

Why need this change? / Root cause:

  • As a user, I want a fast way to join rooms so that I can play games.

Changes made:

  • Add fast join room api.

Test Scope / Change impact:

  • RoomController

Issue

Wally5077
Wally5077 requested changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

Wally5077
Wally5077 requested changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@ricksu978 ricksu978 linked an issue Sep 17, 2023 that may be closed by this pull request
快速加入遊戲房間 #158
Closed
Wally5077
Wally5077 requested changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

Wally5077
Wally5077 approved these changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuoche1712003
feature: fast join api
126bd11 
fix: room controller path

refactor: k linit

refactor: by code review

refactor: by review

refactor: given typo

refactor: by code review

fix: test

refactor: by review
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kuoche1712003 kuoche1712003 merged commit 3690564 into main Sep 24, 2023
@kuoche1712003 kuoche1712003 deleted the feature/fast-join branch September 24, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wally5077 Wally5077 Wally5077 approved these changes

@frankvicky frankvicky frankvicky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

快速加入遊戲房間
3 participants
@kuoche1712003 @Wally5077 @frankvicky