實作最後一人離開房間後則自動關閉房間 #149
Merged
實作最後一人離開房間後則自動關閉房間 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wally5077
requested changes
Aug 17, 2023
Comment on lines
18
to
20
| room.leaveRoom(player.id) | ||
| roomRepository.leaveRoom(room) | ||
| if (room.isEmpty()) roomRepository.deleteById(room.roomId!!) |
There was a problem hiding this comment.
room.leaveRoom(player)
if (room.isEmpty()) {
roomRepository.deleteById(room)
} else {
roomRepository.leaveRoom(room)
}
Wally5077
requested changes
Aug 18, 2023
| roomRepository.leaveRoom(room) | ||
|
|
||
| if (room.isEmpty()) { | ||
| roomRepository.deleteById(room.roomId!!) |
There was a problem hiding this comment.
昨天忘了補充，請幫我將 deleteById 改成下方這樣 🙏
roomRepository.closeRoom(room)
frankvicky
reviewed
Aug 18, 2023
Comment on lines
20
to
23
| if (room.isEmpty()) { | ||
| roomRepository.deleteById(room.roomId!!) | ||
| } else { | ||
| roomRepository.leaveRoom(room) | ||
| } |
ted791029
force-pushed
the
feature/auto-closed-room
branch
from
d2f5812 to
b35993e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change? / Root cause:
Changes made:
Test Scope / Change impact:
Issue