Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomController replace Oidc with JWT #122

Merged
merged 5 commits into from
Jul 16, 2023
Merged

RoomController replace Oidc with JWT #122

merged 5 commits into from
Jul 16, 2023

Conversation

mikaeloduh
Copy link
Contributor

@mikaeloduh mikaeloduh commented Jul 11, 2023 •
edited by ricksu978
Loading

Why need this change? / Root cause:

  • replace Oidc with JWT

Changes made:

Test Scope / Change impact:

Issue

@mikaeloduh mikaeloduh linked an issue Jul 11, 2023 that may be closed by this pull request
RoomController 需要改用 JWT #114
Closed
@mikaeloduh mikaeloduh marked this pull request as ready for review July 11, 2023 08:20
Wally5077
Wally5077 requested changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@mikaeloduh mikaeloduh requested a review from Wally5077 July 11, 2023 15:05
@mikaeloduh mikaeloduh self-assigned this Jul 11, 2023
@mikaeloduh mikaeloduh changed the title test: replace Oidc with JWT RoomController replace Oidc with JWT Jul 13, 2023
@mikaeloduh
Copy link
Contributor Author

@Wally5077 @frankvicky 跟 main 的 conflict 解了

Wally5077
Wally5077 requested changes Jul 16, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikaeloduh mikaeloduh requested a review from Wally5077 July 16, 2023 13:15
Wally5077
Wally5077 approved these changes Jul 16, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikaeloduh mikaeloduh merged commit a9fd076 into main Jul 16, 2023
@mikaeloduh mikaeloduh deleted the feature/room-controller-use-jwt branch July 16, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wally5077 Wally5077 Wally5077 approved these changes

@frankvicky frankvicky frankvicky approved these changes

Assignees

@mikaeloduh mikaeloduh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RoomController 需要改用 JWT
3 participants
@mikaeloduh @Wally5077 @frankvicky