Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

實作離開房間 #101

Merged
merged 3 commits into from
Jul 8, 2023
Merged

實作離開房間 #101

merged 3 commits into from
Jul 8, 2023

Conversation

ted791029
Copy link
Contributor

@ted791029 ted791029 commented Jun 22, 2023 •
edited by ricksu978
Loading

Why need this change? / Root cause:

  • A user want to leave room

Changes made:

  • Room related

Test Scope / Change impact:

  • RoomController

Issue

@ted791029 ted791029 force-pushed the feature/leave-room branch from 97fca61 to 997a9c9 Compare June 22, 2023 04:17
frankvicky
frankvicky requested changes Jun 22, 2023
View reviewed changes
application/src/main/kotlin/tw/waterballsa/gaas/application/usecases/LeaveRoomUsecase.kt Outdated

private fun findRoomById(roomId: Room.Id) =
roomRepository.findById(roomId)
?: throw NotFoundException.notFound(Room::class).id(roomId)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto static import

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修正

Wally5077
Wally5077 requested changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@ted791029 ted791029 force-pushed the feature/leave-room branch 2 times, most recently from 50f3062 to 98e507c Compare July 3, 2023 14:45
Wally5077
Wally5077 requested changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@ted791029 ted791029 force-pushed the feature/leave-room branch 2 times, most recently from 20089e4 to abe295c Compare July 5, 2023 14:40
依據第二次code review修正
9bf739d 
依據第一次code review修正
實作離開房間
@ted791029 ted791029 force-pushed the feature/leave-room branch from abe295c to 9bf739d Compare July 5, 2023 14:41
@ted791029 ted791029 requested review from Wally5077 and frankvicky July 5, 2023 14:43
Wally5077
Wally5077 requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@ted791029 ted791029 requested a review from Wally5077 July 5, 2023 16:20
Wally5077
Wally5077 requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ted791029 ted791029 requested a review from Wally5077 July 5, 2023 23:59
Wally5077
Wally5077 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricksu978 ricksu978 merged commit e3d44f1 into main Jul 8, 2023
@ricksu978 ricksu978 deleted the feature/leave-room branch July 8, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wally5077 Wally5077 Wally5077 approved these changes

@frankvicky frankvicky frankvicky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

離開房間
4 participants
@ted791029 @Wally5077 @frankvicky @ricksu978