Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

feat: switch repo to Next.js #91

Merged
merged 8 commits into from
Jan 31, 2023
Merged

feat: switch repo to Next.js #91

merged 8 commits into from
Jan 31, 2023

Conversation

samerbuna
Copy link
Contributor

@samerbuna samerbuna commented Dec 26, 2022

This PR converts the entire repo to use Next.js (with TS) instead of CRA. It includes a few bug fixes and improvements but no new features or significant changes.

We'll need to change the deploy process:

  • Instead of env var GRAPHQL_URI, the name of the var will now have to be: NEXT_PUBLIC_GRAPHQL_URL
  • To build for production: yarn build
  • No run the production build: yarn start

@sandipndev @krtk6160 @bodymindarts

@samerbuna samerbuna force-pushed the improvments branch 3 times, most recently from 8d975a0 to 931ebb5 Compare December 27, 2022 00:23
galoybot pushed a commit that referenced this pull request Dec 29, 2022
…identity (#91)

* chore: use window.location

* refactor: config structure

* feat: ignore layouts and delete mobile layout

* feat: handle sync session errors

* refactor: config types

* refactor: in config/actions. Add uid to identity

* refactor: rename layouts -> modules

* chore: upgrade dependencies

* chore: remove WALLET_THEME

* fix: use accountStatus from auth endpoint

* fix: include default colors

Co-authored-by: Samer Buna <[email protected]>
@samerbuna
Copy link
Contributor Author

@krtk6160 can we get this PR merged and deployed:

Here are the changes we need for the new deploy:

Instead of env var GRAPHQL_URI, the name of the var will now have to be: NEXT_PUBLIC_GRAPHQL_URL
To build for production: yarn build
No run the production build: yarn start

Copy link
Collaborator

@dolcalmi dolcalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this require changes in docker file?

@samerbuna
Copy link
Contributor Author

does this require changes in docker file?

I don't think so, same yarn build command. but the start command changed and is now done through the next command. Not sure if anything need to change in NGINX.

@bodymindarts
Copy link
Member

I don't think there should be a diff under ./ci or?

@samerbuna
Copy link
Contributor Author

I don't think there should be a diff under ./ci or?

Yeah, no change. Just prettified.

@krtk6160
Copy link
Member

@krtk6160 can we get this PR merged and deployed:

Here are the changes we need for the new deploy:

Instead of env var GRAPHQL_URI, the name of the var will now have to be: NEXT_PUBLIC_GRAPHQL_URL To build for production: yarn build No run the production build: yarn start

GaloyMoney/charts#2391 Will add whatever changes are required to the admin panel chart. I'll build the docker image locally and test with it to see what other changes are needed

@krtk6160 krtk6160 merged commit 36ebdcc into main Jan 31, 2023
galoybot pushed a commit that referenced this pull request Feb 17, 2023
* feat: add funding rate db objects and initial data
* chore: add support sql quesries
* chore: add funding rate repo
* chore: add funding rate handling
* test: add funding rate repo tests
* feat: add funding yields over few tenors
* fix: fix data insert in case table exists
* fix: including services folder to build
* fix: insertion of exchange id foreign key
Co-authored-by: Sebastien Verreault <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants