Bump what4 submodule to version 1.4
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of `what4` includes the changes from GaloisInc/what4#217, which merges the `what4-serialize` library into `what4`. As a result, some of the imports in `semmc` had to be adjusted somewhat. I also bumped the `asl-translator` submodule to bring in the changes from GaloisInc/asl-translator#48, which performed a similar `what4` adaptation. I also bumped the `crucible` submodule to bring in the changes from GaloisIns/crucible#1068, which ensures that everything can build against `tasty-sugar >= 2.0` (the version of the library that `what4-1.4` depends on).
kquick
approved these changes
Mar 21, 2023
RyanGlScott
added a commit
to GaloisInc/macaw
that referenced
this pull request
Mar 21, 2023
The only other changes required are (1) deleting an unused dependency on `what4-serialize`, and (2) raising upper version bounds on `what4`. This brings in submodule changes from the following: * GaloisInc/asl-translator#48, which performed a similar `what4` adaptation. * GaloisInc/semmc#78, which performed a similar `what4` adaptation. * GaloisIns/crucible#1068, which ensures that everything can build against `tasty-sugar >= 2.0` (the version of the library that `what4-1.4` depends on).
RyanGlScott
added a commit
to GaloisInc/macaw
that referenced
this pull request
Mar 21, 2023
The only other changes required are (1) deleting an unused dependency on `what4-serialize`, and (2) raising upper version bounds on `what4`. This brings in submodule changes from the following: * GaloisInc/asl-translator#48, which performed a similar `what4` adaptation. * GaloisInc/semmc#78, which performed a similar `what4` adaptation. * GaloisIns/crucible#1068, which ensures that everything can build against `tasty-sugar >= 2.0` (the version of the library that `what4-1.4` depends on).
RyanGlScott
added a commit
to GaloisInc/macaw-loader
that referenced
this pull request
Mar 22, 2023
The only substantial code change required was to delete an unused dependency on `what4-serialize`. This brings in submodule changes from the following: * GaloisInc/asl-translator#48, which performed a similar `what4` adaptation. * GaloisInc/macaw#328, which performed a similar `what4` adaptation. * GaloisInc/semmc#78, which performed a similar `what4` adaptation. * GaloisIns/crucible#1068, which ensures that everything can build against `tasty-sugar >= 2.0` (the version of the library that `what4-1.4` depends on).
RyanGlScott
added a commit
to GaloisInc/macaw-loader
that referenced
this pull request
Mar 22, 2023
The only substantial code change required was to delete an unused dependency on `what4-serialize`. This brings in submodule changes from the following: * GaloisInc/asl-translator#48, which performed a similar `what4` adaptation. * GaloisInc/macaw#328, which performed a similar `what4` adaptation. * GaloisInc/semmc#78, which performed a similar `what4` adaptation. * GaloisIns/crucible#1068, which ensures that everything can build against `tasty-sugar >= 2.0` (the version of the library that `what4-1.4` depends on).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of
what4includes the changes from GaloisInc/what4#217, which merges thewhat4-serializelibrary intowhat4. As a result, some of the imports insemmchad to be adjusted somewhat.I also bumped the
asl-translatorsubmodule to bring in the changes from GaloisInc/asl-translator#48, which performed a similarwhat4adaptation. I also bumped thecruciblesubmodule to bring in the changes from GaloisIns/crucible#1068, which ensures that everything can build againsttasty-sugar >= 2.0(the version of the library thatwhat4-1.4depends on).