Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Stack #988

Merged
merged 5 commits into from
Jan 13, 2021
Merged

Remove dependency on Stack #988

merged 5 commits into from
Jan 13, 2021

Conversation

atomb
Copy link
Contributor

@atomb atomb commented Jan 5, 2021

This removes the dependency on Stack, in several ways:

  • Removes the use of Stack in the test suite.
  • Updates build.sh to use cabal build.
  • Updates coverage.sh to use cabal build --enable-coverage.
  • Updates the README to describe how to build with cabal.
  • Removes Stack configuration files.

It also fixes a broken test along the way.

@atomb atomb marked this pull request as ready for review January 7, 2021 23:19
@brianhuffman
Copy link
Contributor

I still use stack for local builds (due to its --copy-bins functionality, which I like, and which cabal doesn't have). What does removing the stack configuration files mean for me? Having up-to-date stack.yaml files in the repo is pretty convenient, although I guess if the ones in the repo ever get broken, they become more of a hindrance... and nothing in CI ensures that they don't get broken.

I guess I can probably just maintain my own stack configuration files independently, as long as I want to keep using them. This will probably work fine most of the time; doing old builds (e.g. during bisection) might get a bit trickier if they need different stack configurations, but I guess the stack.yaml files generally don't need to change very often.

@atomb
Copy link
Contributor Author

atomb commented Jan 8, 2021

Thanks for mentioning that, @brianhuffman. My main goal here was to make the central scripts independent of Stack, since we're mostly not using it in CI anymore, but the fact that it's used in the test script could potentially lead to some things being built twice. That doesn't necessarily mean we need to take out the configuration files, though, in case someone wants to use it. I'd be happy to revert that part of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants