Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new saw-script function crucible_points_to_at_type. #970

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Implement new saw-script function crucible_points_to_at_type. #970

merged 2 commits into from
Jan 15, 2021

Conversation

brianhuffman
Copy link
Contributor

Also crucible_conditional_points_to_at_type.

Fixes #930.

andreistefanescu
andreistefanescu reviewed Dec 12, 2020
View reviewed changes
Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's add a test, that would also serve as an example of how to use the command.

@brianhuffman brianhuffman added the needs test Issues for which we should add a regression test label Dec 12, 2020
andreistefanescu
andreistefanescu approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brianhuffman brianhuffman added next-to-merge and removed needs test Issues for which we should add a regression test labels Jan 14, 2021
@brianhuffman brianhuffman merged commit b0cd28d into master Jan 15, 2021
@brianhuffman brianhuffman deleted the points-to-at-type branch January 26, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreistefanescu andreistefanescu andreistefanescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add crucible_pointer_cast and deprecate crucible_points_to_untyped
2 participants
@brianhuffman @andreistefanescu