Error checking for JVMSetup commands #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhuffman
force-pushed
the
jvm-setup-error
branch
from
87d1c72 to
a47c2f3
Compare
brianhuffman
force-pushed
the
jvm-setup-error
branch
from
a47c2f3 to
7f8ff8b
Compare
atomb
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
This is a great improvement. There are still a couple of fail calls in nearby code, and I commented on those. I was just looking at the context provided in the diffs, though, and it may be that those are still fail because they're executing in a context that isn't set up for throwM yet.
| pos <- getPosition | ||
| -- cls' is either cls or a (transitive) superclass of cls |
added 12 commits
December 4, 2020 11:04
Support for static fields is planned using a different mechanism. (See #908.)
This partially addresses #928. This patch only covers the uses of `fail` that were used to implement the JVMSetup commands. There are still a lot of uses of `fail` in other parts of the SAW/JVM code.
Previously it represented the left-hand side with an arbitrary `SetupValue`; however, the only valid `SetupValue`s for this purpose are `SetupVar` applied to an `AllocIndex`. This change lets us simplify code for the simulation phase, in exchange for doing more error checking during the setup phase (which is also a good thing). The early checking eliminates a couple of the known false positives from #938.
This fixes one of the known false positives from #938.
This fixes several more of the known false positives from #938.
This fixes several more of the known false positives from #938.
This fixes more remaining known false positives of #938.
brianhuffman
force-pushed
the
jvm-setup-error
branch
from
7f8ff8b to
8cb78f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few things related to error checking for
JVMSetupblocks:throwMfromexceptionspackage instead offailto report errorsJVMSetupcommands