Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress defaulting warnings from cryptol. #820

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Conversation

brianhuffman
Copy link
Contributor

This incorporates GaloisInc/saw-core#70, which suppresses the
defaulting warning messages upon loading cryptol modules.

Fixes #768.

@brianhuffman
Copy link
Contributor Author

I had forgotten that some of the changes from GaloisInc/saw-core#69 will need changes to saw-script, to avoid ambiguous references after moving a couple of functions from saw-script into cryptol-saw-core. I'll need to make a PR for that first before we merge this one.

@brianhuffman brianhuffman marked this pull request as draft August 21, 2020 17:26
This incorporates GaloisInc/saw-core#70, which suppresses the
defaulting warning messages upon loading cryptol modules.

Fixes #768.
@brianhuffman brianhuffman marked this pull request as ready for review August 21, 2020 20:13
@brianhuffman
Copy link
Contributor Author

I just rebased on top of #821, so now it should work.

@brianhuffman
Copy link
Contributor Author

The ghc-8.8.3 macos build is failing with this error:

<command line>: dlopen(/Users/runner/work/saw-script/saw-script/dist-newstyle/build/x86_64-osx/ghc-8.8.3/llvm-pretty-0.10.3/build/libHSllvm-pretty-0.10.3-inplace-ghc8.8.3.dylib, 5): no suitable image found.  Did find:
	/Users/runner/work/saw-script/saw-script/dist-newstyle/build/x86_64-osx/ghc-8.8.3/llvm-pretty-0.10.3/build/libHSllvm-pretty-0.10.3-inplace-ghc8.8.3.dylib: unknown file type, first eight bytes: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
	/Users/runner/work/saw-script/saw-script/dist-newstyle/build/x86_64-osx/ghc-8.8.3/llvm-pretty-0.10.3/build/libHSllvm-pretty-0.10.3-inplace-ghc8.8.3.dylib: unknown file type, first eight bytes: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
cabal: Failed to build crucible-llvm-0.3 (which is required by
saw-script-0.4.0.99).

The command has failed after 3 attempts.
##[error]Process completed with exit code 1.

I don't see how this failure could possibly be caused by this PR; can anyone explain it?

@brianhuffman
Copy link
Contributor Author

I restarted the CI tests and they failed again in exactly the same way.

@brianhuffman
Copy link
Contributor Author

The failing CI checks are not marked as "required", so I'm going to go ahead and merge anyway.

@brianhuffman brianhuffman merged commit 4bc1836 into master Aug 22, 2020
@brianhuffman brianhuffman deleted the suppress-defaulting branch November 18, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress defaulting warnings
2 participants