Skip to content

eval_ family and list_term tests #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Conversation

ChrisEPhifer
Copy link
Contributor

These tests provide some coverage of the eval_ family of SAWScript primitives (eval_bool, eval_int, eval_list), as well as the inverse of eval_list, list_term.

Given the limited tooling for working with non-Term values in SAWScript, these tests are annotated with comments showing what was printed to standard output for some commands; for most things, this was the only way to confirm they worked as expected. The exception to this is a couple of basic theorems showing that eval_list and list_term behave as inverses on some particular Cryptol terms.

Finally, this testing helped in the discovery of bug #783.

@ChrisEPhifer ChrisEPhifer added the tooling: test infrastructure Issues involving test infrastructure or test execution, or making SAW more testable label Jul 20, 2020
@ChrisEPhifer ChrisEPhifer requested a review from atomb July 20, 2020 21:22
@ChrisEPhifer ChrisEPhifer self-assigned this Jul 20, 2020
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChrisEPhifer ChrisEPhifer merged commit 2631892 into master Jul 21, 2020
@ChrisEPhifer ChrisEPhifer deleted the feature/eval-primitive-tests branch July 21, 2020 02:25
@sauclovian-g sauclovian-g added test assets Issues involving test programs or other test assets and removed tooling: test infrastructure Issues involving test infrastructure or test execution, or making SAW more testable labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test assets Issues involving test programs or other test assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants