Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alloc aligned #648

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Alloc aligned #648

merged 2 commits into from
Feb 11, 2020

Conversation

andreistefanescu
Copy link
Contributor

Fixes #647.

chameco
chameco approved these changes Feb 10, 2020
View reviewed changes
src/SAWScript/Interpreter.hs Outdated Show resolved Hide resolved
src/SAWScript/Crucible/LLVM/Builtins.hs Outdated Show resolved Hide resolved
brianhuffman
brianhuffman suggested changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@brianhuffman brianhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With some small changes to error messages and help text, this looks like it will be ready to go.

Thanks for adding the readonly variant; I had suspected that we might need that eventually.

src/SAWScript/Interpreter.hs Outdated Show resolved Hide resolved
src/SAWScript/Crucible/LLVM/Builtins.hs Outdated Show resolved Hide resolved
@andreistefanescu
Improve alloc_aligned commands.
11a3c8f 
Add `crucible_alloc_readonly_aligned` command. Allow
`crucible_alloc_aligned`/`crucible_alloc_readonly_aligned` to specify an
alignment less than the default alignment of the type.
brianhuffman
brianhuffman approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@brianhuffman brianhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andreistefanescu andreistefanescu merged commit 2d22993 into master Feb 11, 2020
@andreistefanescu andreistefanescu deleted the alloc-aligned branch May 7, 2020 20:26
@brianhuffman brianhuffman mentioned this pull request Jan 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chameco chameco chameco approved these changes

@brianhuffman brianhuffman brianhuffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow crucible_alloc_aligned to specify less alignment than default for type
3 participants
@andreistefanescu @brianhuffman @chameco