Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip call to scGeneralizeExts in crucible verify commands. #629

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

brianhuffman
Copy link
Contributor

@brianhuffman brianhuffman commented Jan 14, 2020

There is no need to convert from external constants to local variables; the proof backends can handle external constants just as well.

Fixes #626.

There is no need to convert from external constants to local
variables; the proof backends can handle external constants
just as well.
@brianhuffman
Copy link
Contributor Author

The travis builds show that the sike proof script is failing. The reason is that it uses quickcheck as a proof tactic, and apparently quickcheck does not handle ExtCns variables. I'll have to fix that.

@andreistefanescu
Copy link
Contributor

the next version of the sike proofs is not using quickcheck. @brianhuffman if handling quickcheck is not trivial, wait a say or two until we start testing using the new version.

For now we convert the goal to a predicate, and convert
any ExtCns variables to lambdas.
@brianhuffman brianhuffman merged commit fe51729 into master Jan 15, 2020
@brianhuffman brianhuffman deleted the no-generalize-exts branch May 17, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to scGeneralizeExts in crucible_llvm_verify is a performance bottleneck
2 participants