Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More typechecking for ghost variables #550

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

langston-barrett
Copy link
Contributor

Fixes #548 and #543

Here's what it looks like on test_ghost_branch_03:

[16:59:17.110] Subgoal failed: h safety assertion: Attempted to mux ghost variables of different types:
Bit
[32]

And in the other case:

  Abort due to false assumption:
    Ghost variable had the wrong type:
    - Expected: [75][8]
    - Actual:   [45][8]
    in _ZN5folly3ssl11OpenSSLHash4Hmac10hash_finalENS_5RangeIPhEE at :123:30

@langston-barrett
Copy link
Contributor Author

This hasn't yet been tested on Fryingpan/Hydra, which is experiencing some evaluation errors: http://fryingpan.dev.galois.com/hydra/jobset/s2n/PR-typecheck-ghost.submodules-ghc865

@langston-barrett
Copy link
Contributor Author

This has passed on Fryingpan: http://fryingpan.dev.galois.com/hydra/build/233554

Copy link
Contributor

@brianhuffman brianhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Muxing and precondition matching for ghost variables should check types
2 participants