Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crucible/LLVM: Five tests of ghost state #541

Merged
merged 4 commits into from
Sep 24, 2019
Merged

Crucible/LLVM: Five tests of ghost state #541

merged 4 commits into from
Sep 24, 2019

Conversation

langston-barrett
Copy link
Contributor

@langston-barrett langston-barrett commented Sep 20, 2019 •
edited
Loading

... plus one split off from #531.

test_ghost_branch_02 currently causes Crucible to crash with a panic.

@langston-barrett langston-barrett added subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm tooling: test infrastructure Issues involving test infrastructure or test execution, or making SAW more testable labels Sep 20, 2019
@langston-barrett langston-barrett changed the title Crucible/LLVM: Three tests ghost state with branching and overrides Crucible/LLVM: Three tests of ghost state with branching and overrides Sep 20, 2019
@langston-barrett langston-barrett mentioned this pull request Sep 20, 2019
Closed
@langston-barrett langston-barrett mentioned this pull request Sep 20, 2019
Closed
@langston-barrett langston-barrett changed the title Crucible/LLVM: Three tests of ghost state with branching and overrides Crucible/LLVM: Five tests of ghost state Sep 20, 2019
@langston-barrett
Copy link
Contributor Author

Passing Fryingpan tests:

atomb
atomb approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

brianhuffman
brianhuffman approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@brianhuffman brianhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@langston-barrett langston-barrett merged commit 829dd76 into GaloisInc:master Sep 24, 2019
@sauclovian-g sauclovian-g added test assets Issues involving test programs or other test assets and removed tooling: test infrastructure Issues involving test infrastructure or test execution, or making SAW more testable labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhuffman brianhuffman brianhuffman approved these changes

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm test assets Issues involving test programs or other test assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@langston-barrett @atomb @brianhuffman @sauclovian-g