Crucible/LLVM: Group argument equality assertions in override matching #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
added
type: enhancement
langston-barrett
added a commit
to langston-barrett/saw-script
that referenced
this pull request
Aug 12, 2019
… matching (GaloisInc#525)" This reverts commit 06b0761.
Merged
langston-barrett
added a commit
to langston-barrett/saw-script
that referenced
this pull request
Aug 19, 2019
…override matching (GaloisInc#525)"" This reverts commit 874d2e6.
langston-barrett
added a commit
to langston-barrett/saw-script
that referenced
this pull request
Aug 19, 2019
… matching (GaloisInc#525)" This reverts commit 06b0761.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522
Currently, Crucible/LLVM override matching is a very sequential, stateful
process. We iterate over the constructions in the method specification
(
crucible_points_to,crucible_equal), accumulating relevant symbolicpredicates in a big list along the way.
This MR begins the process of making this process more declarative, while improving
debugability. It ties the symbolic assertions more closely to the spec.
Next steps: refactor the rest of
learnCondto return lists of labeledpredicates, get rid of assertions stored in
OverrideStateand pass themexplicitly instead.