Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better line number reporting for monadic binds #477

Merged
merged 2 commits into from
Jun 4, 2019

Conversation

langston-barrett
Copy link
Contributor

@langston-barrett langston-barrett commented Jun 3, 2019

Progress on #415

Example improved message:

Abort due to false assumption:
  All overrides failed during structural matching:
  *  Name: EVP_DigestUpdate
     Location: /build/fizz-hkdf/digest.saw:211:3
     Argument types: 
       %struct.env_md_ctx_st*
       i8*
       i64
     Return type: i32
     at /build/fizz-hkdf/sha256.saw:56:3
     error when loading through pointer that appeared in the override's points-to precondition(s):
     Precondition:
       Pointer: symbolic integer:  width = 64
       Pointee: symbolic integer:  width = 32
       Assertion made at: /build/fizz-hkdf/sha256.saw:56:3
     Failure reason: 
       When reading through pointer bvSum c@2346:bv 0x6c:[64]
       Tried to read something of size: 4
       And type: i32
       Found 0 possibly matching allocation(s):

Note that the precondition has a different source location than the override definition site (as opposed to e.g. the message shown in #475). Yay!

@langston-barrett langston-barrett requested a review from atomb June 3, 2019 23:49
@langston-barrett langston-barrett added the topics: error-messages Issues involving the messages SAW produces on error label Jun 3, 2019
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement. And the code all seems straightforward and well-organized.

@langston-barrett langston-barrett merged commit ee7041c into GaloisInc:master Jun 4, 2019
@langston-barrett langston-barrett deleted the positions-2 branch June 4, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topics: error-messages Issues involving the messages SAW produces on error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants