MIR: Achieve feature (+ documentation) parity between SAWScript and Python #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1676. temp
Addresses the request in #1676 (comment)
I accidentally left out some cases in the SAW remote API and the Python bindings for MIR's `char` and reference types. This patch adds them.
RyanGlScott
added
subsystem: saw-remote-api
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a small handful of features in the MIR backend which were implemented in SAWScript but not implemented in Python:
mir_assert. This PR un-deprecates theproclaim()function in the Python bindings, which acts as the Python counterpart tomir_assert. As a side effect, this also fixes Python: Undeprecateproclaim#1676.mir_char,mir_ref, andmir_ref_mut) were missing from the remote API and Python bindings. This PR adds them.In addition, some of the existing parts of the MIR-related Python bindings didn't have docstrings, so this PR adds them as well. This means that all of the user-facing parts of the MIR-related API in the Python bindings should now be documented.