Handle TError in constrant guard translator
#1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using constraint guards in instantiations of parameterized modules, Cryptol may replace impossible constraints with `TError`. To support this behavior, this change adds a case to `importNumericConstraintAsBool` that translates those `TError` constraints to `False`. This is consistent with [`checkProp` in Cryptol](https://github.com/GaloisInc/cryptol/blob/3973b15236ace5c11fdfabbf811d97daee7885ed/src/Cryptol/Eval.hs#L247), which is the Cryptol function that handles evaluation of constraint guard constraints.
bboston7
added
the
subsystem: cryptol-saw-core
RyanGlScott
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using constraint guards in instantiations of parameterized modules, Cryptol may replace impossible constraints with
TError. To support this behavior, this change adds a case toimportNumericConstraintAsBoolthat translates thoseTErrorconstraints toFalse. This is consistent withcheckPropin Cryptol, which is the Cryptol function that handles evaluation of constraint guard constraints (among other things).