Add ogFromParam to Cryptol URI when importing Cryptol names
#1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
requested changes
Aug 23, 2023
RyanGlScott
approved these changes
Aug 23, 2023
qsctr
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAW currently constructs a unique Cryptol URI for each Cryptol name by using the components of the module path and the identifier, but this fails for instantiations of parameterized modules which import multiple interfaces containing parameters with the same name. We fix this by incorporating the identifier from
ogFromParamin theOrigNameif present, which identifies which interface the name came from.Fixes #1892.
(This is my first SAW PR so let me know if I did anything wrong)