Add support for CVC5 #1846
Merged
Add support for CVC5 #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main payload of this commit is to bump the `what4` submodule to bring in the changes from GaloisInc/what4#204. This also brings in a variety of other submodule changes to accommodate this: * GaloisIns/crucible#1068, which ensures that everything can build against `tasty-sugar >= 2.0` (the version of the library that `what4-1.4` depends on). * GaloisInc/cryptol#1504, which adapts Cryptol to CVC5. This adjusts the lower and upper version bounds on SBV in Cryptol, so I do the same here in `saw-core.sbv.cabal` and `saw-script.cabal`. * GaloisInc/language-sally#12, which performs a similar `what4` adaptation. * GaloisInc/macaw#328, which performs a similar `what4` adaptation.
|
@andreistefanescu, I've added you as a reviewer since you indicated an interest in being able to use the changes from GaloisInc/what4#226 in SAW, which this PR achieves as a side effect of bumping the |
chameco
approved these changes
Mar 23, 2023
|
I was perplexed to see that the integration tests were timing out on Windows... but then I remembered that SAW uses SBV-based proof tactics by default, not What4-based ones, so we are most likely running into LeventErkok/sbv#644. I will update the test case to avoid this issue. |
This adds basic support for the CVC5 SMT solver by adding `cvc5` and related proof scripts. I hae added a `test_cvc5` integration test to kick the tires. This addresses one part of #1706.
Sadly, this action is timing out very frequently. I am going to remove it for the sake of getting CI to work. Fixes #1834.
RyanGlScott
added
the
PR: ready to merge
KarmaHaze
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for the CVC5 SMT solver by adding
cvc5and related proof scripts. I have added atest_cvc5integration test to kick the tires.This addresses one part of #1706.