Heapster: Generate definitions for recursive function frames #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction frame, which is used a lot in the generated specs, is made into its own top-level definition
eddywestbrook
added
the
subsystem: heapster
RyanGlScott
approved these changes
Jan 19, 2023
| frameTypeOpenTerm :: OpenTerm | ||
| frameTypeOpenTerm = dataTypeOpenTerm "Prelude.List1" [dataTypeOpenTerm | ||
| "Prelude.LetRecType" []] | ||
|
|
||
| -- | FIXME HERE NOW: docs |
There was a problem hiding this comment.
Is it finally time to fix this FIXME? :)
There was a problem hiding this comment.
That's probably a job for the Fixmen, who answer the age-old question: who fixes the FIXMEs?
Seriously, though, there are a lot of FIXMEs that need to be updated, and this commit is probably not the time...
eddywestbrook
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recursive function frames used in an extracted Heapster spec is a list of inductive encodings of all the recursively-defined function in a spec. This list is a somewhat big Coq term, and is used as an argument to each monadic operation in the spec. This PR refactors this list into its own top-level Coq definition for each function, which reduces the size of specs containing it.